Open
Conversation
…the go_modules group across 1 directory (#281) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…in the go_modules group across 1 directory (#282) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… go_modules group across 1 directory (#290) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…n the go_modules group across 1 directory (#297) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
leoparente
requested review from
MicahParks,
grant-nbl,
jajeffries,
manrodrigues,
mfiedorowicz and
paulstuart
as code owners
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
|
Go test coverage
Total coverage: 59.8% |
Vulnerability Scan: PassedImage:
Commit: 62a93b6 |
mfiedorowicz
approved these changes
Mar 30, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 115413e5cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --mount=type=cache,target=/root/.cache/go-build \ | ||
| --mount=type=cache,target=/go/pkg \ | ||
| CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -ldflags="-s -w" -o /build/orb-agent ./cmd/main.go | ||
| GOOS=$TARGETOS GOARCH=$TARGETARCH EXTRA_LDFLAGS="-s -w" BUILD_DIR=/build make agent_bin |
There was a problem hiding this comment.
make agent_bin
The Docker build now compiles via make agent_bin, but this invocation does not pass BUILD_VERSION/BUILD_BRANCH into Make; agent/version therefore falls back to git describe (or dev) instead of the release version computed by CI, so production images can report incorrect agent version metadata. This is a regression from the previous file-embed path (BUILD_VERSION.txt), which is now ignored by version.go.
Useful? React with 👍 / 👎.
Contributor
There was a problem hiding this comment.
@paulstuart I think this is related to a change you made around versioning. Please could you review this and see if it's correct?
| select { | ||
| case <-ctx.Done(): | ||
| hb.logger.Debug("context done, stopping heartbeats routine") | ||
| hb.sendSingleHeartbeat(context.Background(), heartbeatTopic, publishFunc, agentID, time.Now(), messages.Offline, nil) |
There was a problem hiding this comment.
On cancellation, the heartbeat loop now publishes the final offline heartbeat with context.Background(). If MQTT publish blocks (for example during broker/network issues), stop() waits on hb.wg.Wait() and can hang reconnect/disconnect indefinitely because that publish has no cancellation path or timeout. Using the canceled session context (or a bounded timeout context) avoids blocking the shutdown path.
Useful? React with 👍 / 👎.
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
…n the go_modules group across 1 directory (#307) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
…ort (#306) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.