Add possibility to configure pretty json in .babelish #109

mateuszszklarek · 2018-11-27T14:39:19Z

@netbe it would be great if you could look at it 🚀

houndci-bot · 2018-11-27T14:39:33Z

test/babelish/test_csv2json.rb

+    given_json_filename = 'output.json'
+
+    expected_json = File.read('test/data/' + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, {'English' => "en"}, :output_basename => 'output', pretty_json: true)


Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [118/80]

houndci-bot · 2018-11-27T14:39:33Z

test/babelish/test_csv2json.rb

+    expected_json_filename = 'test_pretty_json.json'
+    given_json_filename = 'output.json'
+
+    expected_json = File.read('test/data/' + expected_json_filename)


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:39:34Z

test/babelish/test_csv2json.rb

+  def test_converting_csv_to_json_with_pretty_json
+    csv_file = "test/data/test_data.csv"
+    expected_json_filename = 'test_pretty_json.json'
+    given_json_filename = 'output.json'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:39:34Z

test/babelish/test_csv2json.rb

+
+  def test_converting_csv_to_json_with_pretty_json
+    csv_file = "test/data/test_data.csv"
+    expected_json_filename = 'test_pretty_json.json'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:39:34Z

test/babelish/test_csv2json.rb

+    given_json_filename = 'output.json'
+
+    expected_json = File.read('test/data/' + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, {'English' => "en"}, :output_basename => 'output', pretty_json: false)


Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [119/80]

houndci-bot · 2018-11-27T14:39:34Z

test/babelish/test_csv2json.rb

+    expected_json_filename = 'test_unpretty_json.json'
+    given_json_filename = 'output.json'
+
+    expected_json = File.read('test/data/' + expected_json_filename)


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:39:34Z

test/babelish/test_csv2json.rb

+  def test_converting_csv_to_json_with_unpretty_json
+    csv_file = "test/data/test_data.csv"
+    expected_json_filename = 'test_unpretty_json.json'
+    given_json_filename = 'output.json'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:39:35Z

test/babelish/test_csv2json.rb

+
+  def test_converting_csv_to_json_with_unpretty_json
+    csv_file = "test/data/test_data.csv"
+    expected_json_filename = 'test_unpretty_json.json'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:39:35Z

lib/babelish/csv2json.rb


    def hash_to_output(content = {})
-      return content.to_json
+      return @pretty_json ? JSON.pretty_generate(content) : content.to_json


Style/RedundantReturn: Redundant return detected.

houndci-bot · 2018-11-27T14:39:35Z

lib/babelish/commandline.rb

    method_option :ignore_lang_path, :type => :boolean, :aliases => "-I", :lazy_default => false, :desc => "Ignore the path component of langs"
    method_option :fetch, :type => :boolean, :desc => "Download file from Google Drive"
    method_option :sheet, :type => :numeric, :desc => "Index of worksheet to download. First index is 0"
+    method_option :pretty_json, :type => :boolean, :aliases => "-p", :desc => "Prettify your json output files"


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [111/80]

houndci-bot · 2018-11-27T14:54:50Z

test/babelish/test_csv2json.rb

+    given_json_filename = "output.json"
+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, { "English" => "en" }, output_basename: 'output', pretty_json: true)


Metrics/LineLength: Line is too long. [117/80]
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T14:54:50Z

test/babelish/test_csv2json.rb

+    given_json_filename = "output.json"
+
+    expected_json = File.read('test/data/' + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, { "English" => "en" }, output_basename: 'output', pretty_json: false)


Metrics/LineLength: Line is too long. [118/80]
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-11-27T15:02:38Z

lib/babelish/commandline.rb

    method_option :ignore_lang_path, :type => :boolean, :aliases => "-I", :lazy_default => false, :desc => "Ignore the path component of langs"
    method_option :fetch, :type => :boolean, :desc => "Download file from Google Drive"
    method_option :sheet, :type => :numeric, :desc => "Index of worksheet to download. First index is 0"
+    method_option :pretty_json, :type => :boolean, aliases: "-p", desc: "Prettify your json output files"


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [105/80]

houndci-bot · 2018-11-27T15:06:58Z

test/babelish/test_csv2json.rb

+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 
+    output_basename: "output", 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-11-27T15:06:58Z

test/babelish/test_csv2json.rb

+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-11-27T15:06:58Z

test/babelish/test_csv2json.rb

+    given_json_filename = "output.json"
+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-11-27T15:06:58Z

test/babelish/test_csv2json.rb

+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 
+    output_basename: "output", 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-11-27T15:06:59Z

test/babelish/test_csv2json.rb

+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-11-27T15:06:59Z

test/babelish/test_csv2json.rb

+    given_json_filename = "output.json"
+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 


Layout/TrailingWhitespace: Trailing whitespace detected.

mateuszszklarek added 5 commits November 26, 2018 15:53

Extend configuration file with pretty_json parameter

fb0c4a3

Update .babelish.sample

5ae5c05

Add alias for pretty_json option

ffb7b19

Refactor csv2base

e58e599

Remove default parameter from commandline.rb

b8eef7e

houndci-bot reviewed Nov 27, 2018

View reviewed changes

Apply fixes according to automatic code review

aa36473

mateuszszklarek force-pushed the feature/pretty-json branch from cb319b8 to aa36473 Compare November 27, 2018 15:02

houndci-bot reviewed Nov 27, 2018

View reviewed changes

Fix formatting in test_csv2json.rb

d7f7ca9

houndci-bot reviewed Nov 27, 2018

View reviewed changes

netbe mentioned this pull request Jun 8, 2020

Feature/pretty json #132

Open

Add possibility to configure pretty json in .babelish #109

Are you sure you want to change the base?

Add possibility to configure pretty json in .babelish #109

Uh oh!

Conversation

mateuszszklarek commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mateuszszklarek commented Nov 27, 2018 •

edited

Loading