feat(config): add override option to ConfigModule#2266
Open
AlexNguetcha wants to merge 1 commit intonestjs:masterfrom
Open
feat(config): add override option to ConfigModule#2266AlexNguetcha wants to merge 1 commit intonestjs:masterfrom
AlexNguetcha wants to merge 1 commit intonestjs:masterfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, @nestjs/config does not allow environment variables in a .env file to override variables already defined in process.env. This is because the internal merging logic prioritizes process.env and filters out existing keys during the assignment phase.
Issue Number: #2261
What is the new behavior?
This PR introduces an override property to ConfigModuleOptions. When set to true:
The internal config object will prioritize values from the .env file over process.env.
The
assignVariablesToProcessmethod will overwrite existing keys in process.env with the values from the loaded configuration.Does this PR introduce a breaking change?
Other information
I have added an E2E test suite in tests/e2e/override-env.spec.ts to verify both the override functionality and the preservation of the default behavior.