fix(mailer): use logger.log instead of debug for transporter ready#1249
Closed
shishir-subedii wants to merge 1 commit intonest-modules:mainfrom
Closed
fix(mailer): use logger.log instead of debug for transporter ready#1249shishir-subedii wants to merge 1 commit intonest-modules:mainfrom
shishir-subedii wants to merge 1 commit intonest-modules:mainfrom
Conversation
juandav
added a commit
that referenced
this pull request
Mar 21, 2026
- fix(service): use logger.log instead of debug for transporter ready message (#1239, #1248, #1249) - fix(service): reuse createTransporter in addTransporter for consistent verification and hooks (#1234) - fix(liquid): initialize config with default empty object to prevent TypeError (#1232) - fix(mjml): add optional chaining for others param to prevent crash when undefined - fix(deps): add peerDependenciesMeta to mark template engines as optional (#1238, #1244) - fix(deps): move tslib from devDependencies to dependencies for PnP runtime support (#1230) - chore(deps): update devDependencies to latest compatible versions (#1242, #1250) - docs: add Liquid adapter examples, MJML clarifications, multi-transporter docs (#1246) - docs: add pnpm installation instructions and liquidjs to README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
juandav
added a commit
that referenced
this pull request
Mar 21, 2026
- fix(service): use logger.log instead of debug for transporter ready message (#1239, #1248, #1249) - fix(service): reuse createTransporter in addTransporter for consistent verification and hooks (#1234) - fix(liquid): initialize config with default empty object to prevent TypeError (#1232) - fix(mjml): add optional chaining for others param to prevent crash when undefined - fix(deps): add peerDependenciesMeta to mark template engines as optional (#1238, #1244) - fix(deps): move tslib from devDependencies to dependencies for PnP runtime support (#1230) - chore(deps): update devDependencies to latest compatible versions (#1242, #1250) - docs: add Liquid adapter examples, MJML clarifications, multi-transporter docs (#1246) - docs: add pnpm installation instructions and liquidjs to README Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Superseded by branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when the mail transporter is successfully verified, the message
Transporter is readyis logged withlogger.debug.This means developers only see this confirmation when debug-level logging
is enabled. However, the transporter being ready is an important success
state that should be visible under standard logging.
Change
this.mailerLogger.debugwiththis.mailerLogger.logfor the"Transporter is ready" message.
Reasoning
log().Notes
If maintainers prefer not to show this message at
loglevel, an alternativewould be to make the log level configurable.