refactor: ensure transporter.verify returns a promise#1145
Open
mahdichaari01 wants to merge 4 commits intonest-modules:mainfrom
Open
refactor: ensure transporter.verify returns a promise#1145mahdichaari01 wants to merge 4 commits intonest-modules:mainfrom
mahdichaari01 wants to merge 4 commits intonest-modules:mainfrom
Conversation
mahdichaari01
changed the title
Clashsoft
reviewed
Apr 27, 2024
Comment on lines
+111
to
+112
| .then(() => this.mailerLogger.log(`Transporter${transporterName} is ready`)) | ||
| .catch((error) => this.mailerLogger.log(`Error occurred while verifying the transporter${transporterName}}: ${error.message}`)); |
There was a problem hiding this comment.
Why change the log level (debug/error -> log)?
Author
There was a problem hiding this comment.
True, the point here is to just wrap it in a promise and keep the default behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue within the @nestjs-modules/mailer library, where the transport.verify function is executed even though it's marked as optional in the nodemailer typings. This causes failures, especially with transport configurations lacking the verify function, such as streamTransport.
Related Issues
This PR is a proposed fix to #1144.