feat: enable typescript strict mode for null-checking#288
Closed
nidomiro wants to merge 1 commit intonest-modules:mainfrom
Closed
feat: enable typescript strict mode for null-checking#288nidomiro wants to merge 1 commit intonest-modules:mainfrom
nidomiro wants to merge 1 commit intonest-modules:mainfrom
Conversation
juandav
added a commit
that referenced
this pull request
Mar 22, 2026
…dling - Add OnApplicationShutdown to RedisCoreModule for graceful Redis disconnection (PR #289) - Fix health provider to use configured Redis connection instead of default localhost (PR #281) - Add null-safe error handling in RedisHealthIndicator (PR #288) - Export redisHealthIndicatorProvider from index Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Hi @nidomiro, thanks for this PR! The null-safe error handling improvements from your PR have been incorporated into the main branch (commit Regarding TypeScript strict mode — the codebase has been migrated to a monorepo structure with Biome for linting, and we're evaluating strict mode as a separate effort. Closing this PR as the relevant changes have been merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables typescripts 'strict' option for null-checking