Skip to content

add Compile Protocol Buffer#4

Open
duanjie-cmd wants to merge 1 commit intomainfrom
dev
Open

add Compile Protocol Buffer#4
duanjie-cmd wants to merge 1 commit intomainfrom
dev

Conversation

@duanjie-cmd
Copy link
Collaborator

No description provided.

Copy link

@fielding fielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go.. only things I was going to ask about was missing newlines at the end of files (helps with consistency in VCS across different environments and the other thing has to do with pagination and all repeated fields. Do you think we need?

@duanjie-cmd
Copy link
Collaborator Author

I think this is good to go.. only things I was going to ask about was missing newlines at the end of files (helps with consistency in VCS across different environments and the other thing has to do with pagination and all repeated fields. Do you think we need?

  1. Add a newline to the end of the file.
    image
  2. We do is compile the proto file into a ts file. The content of the ts file depends on the compilation tool. I don't think it needs to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants