Skip to content

Potential fix for 1 code quality finding #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
codewizdave wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for 1 code quality finding #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions packages/sdk/src/modules/repos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,32 @@ export async function reposRead(
}

// All requests succeeded - extract the file contents
const files = results
const fileResults = results
.filter(isOk)
.map((result) => {
.map((result, index) => {
const response = result.value;
const entry = Array.isArray(response) ? response[0]! : response;
return mapFileContent(entry);
if (Array.isArray(response)) {
if (response.length === 0) {
return err(ReposError({
message: "Empty contents response for path",
statusCode: null,
repo,
path: cleanedPaths[index]
}));
}
return ok(mapFileContent(response[0]));
}
return ok(mapFileContent(response));
});

for (const fileResult of fileResults) {
if (isErr(fileResult)) {
return fileResult;
}
}

const files = fileResults.filter(isOk).map((result) => result.value);

return ok({ repo, files });
}

Expand Down
Loading