Skip to content

feat: improve setup with optional key and verification #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FFFergie wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −1
Open

feat: improve setup with optional key and verification #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion cmd/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"runtime"
"strings"

"github.com/ashrafali/craft-cli/internal/api"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -129,11 +130,21 @@ func runSetup() error {
fmt.Printf(" Using name: %s\n", profileName)
}

fmt.Println()
fmt.Print("Optional API key (press Enter to skip): ")
setupAPIKey, err := reader.ReadString('\n')
if err != nil {
return fmt.Errorf("failed to read input: %w", err)
}
setupAPIKey = strings.TrimSpace(setupAPIKey)

// Save profile
if err := cfgManager.AddProfile(profileName, apiURL); err != nil {
if err := cfgManager.AddProfileWithKey(profileName, apiURL, setupAPIKey); err != nil {
return fmt.Errorf("failed to save profile: %w", err)
}

printSetupVerification(apiURL, setupAPIKey)

// Success!
printSuccess(profileName)

Expand Down Expand Up @@ -192,6 +203,32 @@ func printSuccess(profileName string) {
fmt.Println()
}

func printSetupVerification(apiURL, apiKey string) {
fmt.Println()
fmt.Println("Verifying connection and permissions...")
fmt.Println()

client := api.NewClient(apiURL)
if apiKey != "" {
client = api.NewClientWithKey(apiURL, apiKey)
}

if _, err := client.GetConnection(); err != nil {
fmt.Printf("✗ Connectivity: Failed (%v)\n", err)
} else {
fmt.Println("✓ Connectivity: OK")
}

if _, err := client.GetDocuments(); err != nil {
fmt.Printf("✗ Read: Denied (%v)\n", err)
} else {
fmt.Println("✓ Read: Allowed")
}

fmt.Println(" Write: Use 'craft create --dry-run' to test")
fmt.Println(" Delete: Use 'craft delete --dry-run' to test")
}

func promptYesNo(reader *bufio.Reader, question string, defaultYes bool) bool {
defaultHint := "Y/n"
if !defaultYes {
Expand Down