Extend alerting email to managers #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
knikolla
commented
Dec 16, 2025
knikolla
commented
- Introduces a new get_managers function that gets the list of managers with enabled notifications.
- Switches from Django's send_mail to ColdFront's send_email because of CC support and better error handling.
- Removes EMAIL_ENABLED since that is built into send_email now.
- Fixes some bugs with parameter passing that slipped through review due to missing unit tests.
- Added unit test.
- Introduces a new get_managers function that gets the list of
managers with enabled notifications.
- Switches from Django's send_mail to ColdFront's send_email
because of CC support and better error handling.
- Removes EMAIL_ENABLED since that is built into send_email now.
- Fixes some bugs with parameter passing that slipped through
review due to missing unit tests.
- Added unit test.
QuanMPhm
reviewed
Dec 16, 2025
src/coldfront_plugin_cloud/management/commands/fetch_daily_billable_usage.py
Outdated
Show resolved
Hide resolved
src/coldfront_plugin_cloud/management/commands/fetch_daily_billable_usage.py
Outdated
Show resolved
Hide resolved
…lable_usage.py Co-authored-by: Quan Pham <qmpham2019@gmail.com>
knikolla
force-pushed
the
fix_daily_email
branch
2 times, most recently
from
cb90793 to
a2768a4
Compare
knikolla
force-pushed
the
fix_daily_email
branch
from
a2768a4 to
5bcf96b
Compare
QuanMPhm
approved these changes
Dec 16, 2025
naved001
reviewed
Dec 16, 2025
src/coldfront_plugin_cloud/management/commands/fetch_daily_billable_usage.py
Show resolved
Hide resolved
naved001
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.