Skip to content

Feature/add option for sql encryption#26

Open
NikoBergemann-Sii wants to merge 10 commits intoneosmart:masterfrom
NikoBergemann-Sii:feature/addOptionForSqlEncryption
Open

Feature/add option for sql encryption#26
NikoBergemann-Sii wants to merge 10 commits intoneosmart:masterfrom
NikoBergemann-Sii:feature/addOptionForSqlEncryption

Conversation

@NikoBergemann-Sii
Copy link
Copy Markdown

I saw you responding to an issue #18 by saying that you want to leave the security to the filesystem - would you be so kind as to explain this decision further?

We have the need to encrypt our sqlite database because multiple entites have access to the shared filesystem where multiple DB files are to be stored for the different user groups.

Please have a look at the changes and feel free to critique them - since this is my first ever attempt at contributing to an Open source project I am eager to learn the do's and dont's.

The tests are not actually encrypting the DB at the moment because we are not using a provider that supports it.
I just extended them to be able to verify that adding the Password-option does not break anything when using the classic sqlite providers.

@NikoBergemann-Sii
Copy link
Copy Markdown
Author

"The tests are not actually encrypting the DB at the moment because we are not using a provider that supports it.
I just extended them to be able to verify that adding the Password-option does not break anything when using the classic sqlite providers."

Nevermind, i just found the dumb inverted if - statement
If you use the Password as part of the connectionstring without the appropriate provider it absolutely breaks the connection 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants