Feature/add option for sql encryption#26
Open
NikoBergemann-Sii wants to merge 10 commits intoneosmart:masterfrom
Open
Feature/add option for sql encryption#26NikoBergemann-Sii wants to merge 10 commits intoneosmart:masterfrom
NikoBergemann-Sii wants to merge 10 commits intoneosmart:masterfrom
Conversation
…onString utilizing SQLite with encryption
Author
|
"The tests are not actually encrypting the DB at the moment because we are not using a provider that supports it. Nevermind, i just found the dumb inverted if - statement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw you responding to an issue #18 by saying that you want to leave the security to the filesystem - would you be so kind as to explain this decision further?
We have the need to encrypt our sqlite database because multiple entites have access to the shared filesystem where multiple DB files are to be stored for the different user groups.
Please have a look at the changes and feel free to critique them - since this is my first ever attempt at contributing to an Open source project I am eager to learn the do's and dont's.
The tests are not actually encrypting the DB at the moment because we are not using a provider that supports it.
I just extended them to be able to verify that adding the Password-option does not break anything when using the classic sqlite providers.