ProfiledPlan: expose existence for all metrics#1396
Open
robsdedude wants to merge 6 commits intoneo4j:6.xfrom
Open
ProfiledPlan: expose existence for all metrics#1396robsdedude wants to merge 6 commits intoneo4j:6.xfrom
robsdedude wants to merge 6 commits intoneo4j:6.xfrom
Conversation
Member
Author
|
Please don't merge yet. I'd like to wait for this work to be ready for merging across all drivers first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
ResultSummary.profileof typeProfiledPlanin favor ofResultSummary.queryProfileof typeProfile.The main difference between the profile types is that the new one exposes whether stats (such as
dbHits,time, etc.) have been recorded by being nullable.According to a chat with the Cypher runtime team, the absence of the value is not equivalent to it being zero. Therefore it makes sense to express this information in the API. The information is encoded in the bolt protocol through absence or existence of the respective fields.
Closes: DRIVERS-283
Depends on: