Skip to content

ProfiledPlan: expose existence for all metrics#1396

Open
robsdedude wants to merge 6 commits intoneo4j:6.xfrom
robsdedude:summary/expose-profile-metrics-existence
Open

ProfiledPlan: expose existence for all metrics#1396
robsdedude wants to merge 6 commits intoneo4j:6.xfrom
robsdedude:summary/expose-profile-metrics-existence

Conversation

@robsdedude
Copy link
Copy Markdown
Member

@robsdedude robsdedude commented Mar 10, 2026

Deprecate ResultSummary.profile of type ProfiledPlan in favor of ResultSummary.queryProfile of type Profile.

The main difference between the profile types is that the new one exposes whether stats (such as dbHits, time, etc.) have been recorded by being nullable.

According to a chat with the Cypher runtime team, the absence of the value is not equivalent to it being zero. Therefore it makes sense to express this information in the API. The information is encoded in the bolt protocol through absence or existence of the respective fields.

Closes: DRIVERS-283

Depends on:

@robsdedude robsdedude requested a review from MaxAake April 13, 2026 09:20
@robsdedude robsdedude marked this pull request as ready for review April 13, 2026 09:20
@robsdedude
Copy link
Copy Markdown
Member Author

Please don't merge yet. I'd like to wait for this work to be ready for merging across all drivers first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant