[Snyk] Upgrade jimp from 0.16.1 to 0.22.12

[nejidevelops]

Snyk has created this PR to upgrade jimp from 0.16.1 to 0.22.12.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

---

• The recommended version is 111 versions ahead of your current version.

• The recommended version was released 2 years ago.

Issues fixed by the recommended upgrade:

	Issue	Score	Exploit Maturity
	Denial of Service (DoS) SNYK-JS-JPEGJS-2859218	452	Proof of Concept
	Regular Expression Denial of Service (ReDoS) SNYK-JS-BABELRUNTIME-10044504	452	Proof of Concept
	Prototype Pollution SNYK-JS-MINDOCUMENT-13045385	452	Proof of Concept
	Exposure of Sensitive Information to an Unauthorized Actor SNYK-JS-PHIN-6598077	452	No Known Exploit
	Prototype Pollution SNYK-JS-XML2JS-5414874	452	Proof of Concept
	Prototype Pollution SNYK-JS-MINIMIST-2429795	452	Proof of Concept

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• This PR was automatically created by Snyk using the credentials of a real user.
• Max score is 1000. Note that the real score may have changed since the PR was raised.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

• 🧐 View latest project report
• 📜 Customise PR templates
• 🛠 Adjust upgrade PR settings
• 🔕 Ignore this dependency or unsubscribe from future upgrade PRs

[gemini-code-assist]

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on a critical update to the jimp image processing library. The primary goal is to enhance the project's security and stability by upgrading to version 0.22.12, which resolves a range of known vulnerabilities. This update also involves a comprehensive refresh of associated dependencies, bringing the project's package ecosystem up-to-date.

Highlights

• Jimp Library Upgrade: The jimp image processing library has been upgraded from version 0.16.1 to 0.22.12.
• Security Vulnerability Resolution: This upgrade addresses multiple security vulnerabilities, including Denial of Service (DoS), Regular Expression Denial of Service (ReDoS), Prototype Pollution, and Exposure of Sensitive Information to an Unauthorized Actor, as identified by Snyk.
• Dependency Updates: Numerous sub-dependencies of jimp and other packages have been updated, and several new dependencies have been introduced to support the new jimp version, ensuring compatibility and leveraging the latest improvements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Upgrade jimp to ESM-only release breaks CommonJS import

The application imports jimp with import Jimp = require('jimp') and the TS compiler emits CommonJS modules. Version 0.22 of jimp is published as a pure ES module that cannot be loaded via require, and it also targets newer Node runtimes (>=16/18). After this bump, starting the server will throw ERR_REQUIRE_ESM when filterImageFromURL executes, so the image filter service no longer boots. Either keep a CJS-compatible jimp (≤0.21) or migrate the codebase and runtime to ESM before upgrading.

Useful? React with 👍 / 👎.

[gemini-code-assist]

Code Review

This pull request upgrades jimp from 0.16.1 to 0.22.12, which is an important step to resolve multiple security vulnerabilities.

However, this large version jump introduces a critical breaking change in the jimp API that must be addressed before this PR can be merged. The current code that uses jimp will likely fail or exhibit race conditions with this new version.

Critical: Update jimp Usage

The jimp library made its write() method asynchronous from v0.18.0 onwards. The filterImageFromURL function in src/util/util.ts uses a new Promise constructor with a callback for write(), which is an anti-pattern and will not work correctly with the new version.

I strongly recommend refactoring filterImageFromURL to correctly use async/await and also to fix a pre-existing path-handling bug.

Suggested replacement for filterImageFromURL in src/util/util.ts:

import fs from "fs";
import Jimp = require("jimp");
import path from "path";

export async function filterImageFromURL(inputURL: string): Promise<string> {
  const photo = await Jimp.read(inputURL);
  const outpath = path.join(__dirname, "..", "tmp", `filtered.${Math.floor(Math.random() * 2000)}.jpg`);
  
  await photo
    .resize(256, 256)
    .quality(60)
    .greyscale()
    .writeAsync(outpath);

  return outpath;
}

This change:

1. Removes the new Promise anti-pattern.
2. Uses writeAsync(), the correct promise-based API for jimp.
3. Fixes the file path to correctly use the www/tmp/ directory. You'll need to add import path from "path";.

High: Other Outdated & Vulnerable Dependencies

While reviewing, I noticed other dependencies that should be updated to patch security vulnerabilities and stay current. Please consider creating separate PRs for these:

• express: Upgrade from ^4.17.1 to ^4.18.2 to fix known high-severity vulnerabilities.
• lodash: The package.json lists ^4.17.15, which has known vulnerabilities. While the lockfile has correctly resolved this to 4.17.21, it's best to update package.json to ^4.17.21 to be explicit and prevent accidental downgrades.
• Dev Dependencies: typescript, @types/node, and ts-node-dev are very outdated. Also, tslint is deprecated and should be migrated to ESLint.

Because of the critical breaking change, this PR is not safe to merge as is. The code using jimp must be updated.