Fix/critical safety and modernization#25
Merged
nehalkpatel merged 2 commits intomainfrom Jan 19, 2026
Merged
Conversation
Reduce CLAUDE.md from 820 to 92 lines, focusing on essential guidance for AI assistants: build commands, architecture pattern, constraints, and code patterns. Remove information discoverable from source files. Reduce README.md from 277 to 117 lines, keeping quick start options, architecture overview, and essential commands while removing redundant sections. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Critical fixes: - Wrap JSON parsing in try-catch to handle exceptions safely (RTTI disabled) - Change I2C ReceiveData to use caller-provided buffer instead of returning span to internal storage (prevents dangling references) - Fix ZmqTransport race condition with proper condition variable sync instead of sleep_for hack Modernization: - Add [[nodiscard]] to all error-returning interface methods - Replace manual operator== with defaulted spaceship operator<=> - Use std::println instead of iostream in logger - Use std::as_bytes instead of reinterpret_cast in uart_echo Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nehalkpatel
force-pushed
the
fix/critical-safety-and-modernization
branch
from
392e22d to
bfe909c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.