Skip to content

Update OpenMC#1295

Merged
aprilnovak merged 16 commits intoneams-th-coe:develfrom
nuclearkevin:update_openmc
Mar 3, 2026
Merged

Update OpenMC#1295
aprilnovak merged 16 commits intoneams-th-coe:develfrom
nuclearkevin:update_openmc

Conversation

@nuclearkevin
Copy link
Copy Markdown
Member

Closes #1292

@nuclearkevin
Copy link
Copy Markdown
Member Author

@aprilnovak it appears that this will require an update to the CIVET recipe (removing the XTensor submodule checkout) to get tests to run.

@aprilnovak
Copy link
Copy Markdown
Collaborator

ok, let's get #1288 in first (to support a user request) and then I'll update the civet_recipes

@moosebuild
Copy link
Copy Markdown
Collaborator

Job Apptainer openmpi on ecfa336 : invalidated by @aprilnovak

@aprilnovak
Copy link
Copy Markdown
Collaborator

ok actually let's do this one first, can you refresh this PR?

@nuclearkevin nuclearkevin force-pushed the update_openmc branch 2 times, most recently from 4a2cfe2 to 12fb41f Compare February 23, 2026 17:34
@nuclearkevin
Copy link
Copy Markdown
Member Author

@aprilnovak looks like the CIVET recipe is still attempting to check out the XTensor submodules.

@meltawila
Copy link
Copy Markdown
Member

Can we also include openmc-dev/openmc#3766 in the submodule update, as we need it for the slab benchmark docs.?

@nuclearkevin
Copy link
Copy Markdown
Member Author

Assuming it gets merged into OpenMC-develop in a reasonable timeframe, sure.

@moosebuild
Copy link
Copy Markdown
Collaborator

Job Test OpenMC on 12fb41f : invalidated by @aprilnovak

Comment thread src/base/OpenMCCellAverageProblem.C
@moosebuild
Copy link
Copy Markdown
Collaborator

Job Precheck, step Clang format on a04f515 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/1295/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 49fd7faa9aee62fa594d878e2f591cde41e5e099

@moosebuild
Copy link
Copy Markdown
Collaborator

moosebuild commented Feb 28, 2026

Job Documentation, step Sync to remote on 7399145 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Copy Markdown
Collaborator

moosebuild commented Feb 28, 2026

Job Coverage, step Generate coverage on 7399145 wanted to post the following:

Coverage

49fd7f #1295 739914
Total Total +/- New
Rate 93.15% 93.16% +0.01% 100.00%
Hits 9782 9779 -3 45
Misses 719 718 -1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@nuclearkevin
Copy link
Copy Markdown
Member Author

@aprilnovak I've added a page for the Doppler slab problem under V&V. Should be ready for you to review now!

Comment thread doc/content/vv/doppler_slab.md Outdated
Comment thread doc/content/vv/doppler_slab.md Outdated
Comment thread doc/content/vv/doppler_slab.md Outdated
Comment thread test/tests/neutronics/mg/doppler_slab_lin/solid.i Outdated
Comment thread test/tests/neutronics/mg/doppler_slab_lin/solid.i Outdated
@aprilnovak
Copy link
Copy Markdown
Collaborator

Thanks @nuclearkevin ! Looks good, only minor comments

@aprilnovak aprilnovak merged commit 92537e2 into neams-th-coe:devel Mar 3, 2026
10 checks passed
@nuclearkevin nuclearkevin deleted the update_openmc branch March 3, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OpenMC

4 participants