Conversation
…existence of user's manager config, and if it is missing triggers the previous 'init' logic - added preview of affected paths within init function, and asks user for confirmation that they wish to make these changes - this should only occur the first time the user leverages the system
- updated tests to account for the fact that the individual test environment will need the prompt answered in every test - resolved bug in which icrn_manager used old style kernel path headings instead of new-style language defaults
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| ICRN_PYTHON_KERNELS=${ICRN_KERNEL_REPOSITORY}"/"$(jq -r ".\"icrn_python_kernels\"" "${ICRN_MANAGER_CONFIG}") | ||
| ICRN_KERNEL_CATALOG=${ICRN_KERNEL_REPOSITORY}"/"$(jq -r ".\"icrn_kernel_catalog\"" "${ICRN_MANAGER_CONFIG}") | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Bug: Auto-init triggers even with empty/missing subcommand
The kernels() function checks [ "$cmdname" != "init" ] before validating that cmdname is non-empty. When a user runs icrn_manager kernels without specifying a subcommand, cmdname is empty string, which doesn't equal "init", so check_and_init_if_needed() is called prompting for initialization. Only afterwards does the code check if cmdname is empty to display the help message. The empty command check at line 1073 should occur before the auto-initialization logic.
Note
Auto-initializes ICRN Manager on demand, switches catalog layout to R/Python, enhances init with path preview/confirmation, and updates docs/tests accordingly.
check_and_init_if_needed;kernels()reloads config post-init.kernels__init: show paths to be created/modified, prompt for confirmation; supports updating central path; writes config usingR/Pythonsubpaths.RandPython; references updated throughout.icrn_manager_with_confirm), switched mock repo toR/Pythonlayout.tests/cleanup_tests.sh; expandedtests/README.mdwith suite details and usage; removed committedtests/test_results.log.Deploy.md: added kernel indexer run steps and web server run instructions with bind mounts.documentation/catalog_resources/README.md: updated directory structure and examples toR/Pythonhierarchy.update_r_libs.sh: updatedICRN_R_KERNELSpath toR/.Written by Cursor Bugbot for commit 3cc5690. This will update automatically on new commits. Configure here.