Fix: Added fallback decoding for Base64 encoded strings#211
Open
Chvalov wants to merge 2 commits intonccgroup:masterfrom
Open
Fix: Added fallback decoding for Base64 encoded strings#211Chvalov wants to merge 2 commits intonccgroup:masterfrom
Chvalov wants to merge 2 commits intonccgroup:masterfrom
Conversation
- Updated `importWStalker` method to handle both standard and URL-safe Base64 encoded strings. - Standard Base64 decoding is attempted first, with a fallback to URL-safe decoding if an IllegalArgumentException is thrown. This change addresses the issue where some Base64 encoded strings were causing decoding failures due to illegal characters.
Author
|
This fix was already provided earlier 19aefdf, it's strange that the current version contains the problematic code 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an issue where the
importWStalkermethod in theLoggerImportclass fails to decode certain Base64 encoded strings due to illegal characters. The error stack trace indicates anIllegalArgumentExceptionis thrown when trying to decode these strings.To fix this issue, I implemented a two-step decoding process:
First, attempt to decode using standard Base64.
If standard Base64 decoding fails, catch the
IllegalArgumentExceptionand attempt to decode using URL-safe Base64.This approach ensures that both standard and URL-safe Base64 encoded strings are correctly processed.
This change addresses the issue where some Base64 encoded strings were causing decoding failures due to illegal characters.