Skip to content

fix(playlist): sanitize playlist names to prevent path traversal via '/' #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berettavexee wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(playlist): sanitize playlist names to prevent path traversal via '/' #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions streamrip/media/playlist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from ..console import console
from ..db import Database
from ..exceptions import NonStreamableError
from ..filepath_utils import clean_filepath
from ..filepath_utils import clean_filename, clean_filepath
from ..metadata import (
AlbumMetadata,
Covers,
Expand Down Expand Up @@ -171,7 +171,7 @@ async def resolve(self) -> Playlist | None:
return None
name = meta.name
parent = self.config.session.downloads.folder
folder = os.path.join(parent, clean_filepath(name))
folder = os.path.join(parent, clean_filepath(clean_filename(name)))
tracks = [
PendingPlaylistTrack(
id,
Expand Down Expand Up @@ -243,7 +243,7 @@ def callback():
results: list[tuple[str | None, bool]] = await asyncio.gather(*requests)

parent = self.config.session.downloads.folder
folder = os.path.join(parent, clean_filepath(playlist_title))
folder = os.path.join(parent, clean_filepath(clean_filename(playlist_title)))

pending_tracks = []
for pos, (id, from_fallback) in enumerate(results, start=1):
Expand Down