fix: update default Angular LS and TypeScript versions#84
Merged
notpeter merged 1 commit intonathansbradshaw:mainfrom Mar 14, 2026
Merged
fix: update default Angular LS and TypeScript versions#84notpeter merged 1 commit intonathansbradshaw:mainfrom
notpeter merged 1 commit intonathansbradshaw:mainfrom
Conversation
Update @angular/language-server from 19.0.4 to 21.1.5 and TypeScript
from 5.7.3 to 5.9.3.
Angular v21 moved type declarations from @angular/core/core.d.ts to
@angular/core/types/core.d.ts. The v19 language server's project
detection checks for path.endsWith("@angular/core/core.d.ts") which
no longer matches, causing it to disable the language service with
"project is not an Angular project ('@angular/core' could not be
found)". The v21 language server uses a regex that matches any .d.ts
file under @angular/core/.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the default versions of Angular Language Server and TypeScript dependencies to support Angular v21+ projects. Angular v21 changed the location of type declarations from @angular/core/core.d.ts to @angular/core/types/core.d.ts, which breaks project detection in the v19 language server. The v21 language server uses a regex pattern that correctly handles the new path structure.
Changes:
- Updates
@angular/language-serverdefault version from 19.0.4 to 21.1.5 - Updates
typescriptdefault version from 5.7.3 to 5.9.3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
notpeter
approved these changes
Mar 14, 2026
Collaborator
notpeter
left a comment
notpeter
left a comment
There was a problem hiding this comment.
This seems sane to me.
github-merge-queue bot
pushed a commit
to zed-industries/extensions
that referenced
this pull request
Mar 18, 2026
Includes: - Diff: nathansbradshaw/zed-angular@v0.0.4...v0.0.5 - nathansbradshaw/zed-angular#84 - nathansbradshaw/zed-angular#80 - nathansbradshaw/zed-angular#82 - nathansbradshaw/zed-angular#67 - nathansbradshaw/zed-angular#60 Update tree-sitter-angular to v0.8.3: - Diff: dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685 - Complex CSS classes breaking parsing - Template string as primitive - Hyphen in identifier - Percentage sign as unit for style property binding - Class attribute modifier starting with hyphen Closes: nathansbradshaw/zed-angular#71
cramhead
pushed a commit
to cramhead/extensions
that referenced
this pull request
Mar 31, 2026
Includes: - Diff: nathansbradshaw/zed-angular@v0.0.4...v0.0.5 - nathansbradshaw/zed-angular#84 - nathansbradshaw/zed-angular#80 - nathansbradshaw/zed-angular#82 - nathansbradshaw/zed-angular#67 - nathansbradshaw/zed-angular#60 Update tree-sitter-angular to v0.8.3: - Diff: dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685 - Complex CSS classes breaking parsing - Template string as primitive - Hyphen in identifier - Percentage sign as unit for style property binding - Class attribute modifier starting with hyphen Closes: nathansbradshaw/zed-angular#71
pataruco
pushed a commit
to pataruco/extensions
that referenced
this pull request
Apr 15, 2026
Includes: - Diff: nathansbradshaw/zed-angular@v0.0.4...v0.0.5 - nathansbradshaw/zed-angular#84 - nathansbradshaw/zed-angular#80 - nathansbradshaw/zed-angular#82 - nathansbradshaw/zed-angular#67 - nathansbradshaw/zed-angular#60 Update tree-sitter-angular to v0.8.3: - Diff: dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685 - Complex CSS classes breaking parsing - Template string as primitive - Hyphen in identifier - Percentage sign as unit for style property binding - Class attribute modifier starting with hyphen Closes: nathansbradshaw/zed-angular#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually a series a fixes to make that extension work again. You can try out the extension locally over at https://github.com/pmig/zed-angular. Although most of the code was written by claude, I (@pmig) manually reviewed and tested it.
Summary
@angular/language-serverdefault from 19.0.4 to 21.1.5typescriptdefault from 5.7.3 to 5.9.3Angular v21 moved type declarations from
@angular/core/core.d.tsto@angular/core/types/core.d.ts. The v19 language server's project detection usespath.endsWith("@angular/core/core.d.ts")which no longer matches, causing it to disable the language service entirely with the message: "project is not an Angular project ('@angular/core' could not be found)".The v21 language server uses a regex (
/@angular\/core\/.+\.d\.ts$/) that correctly matches the new path structure.This is the root cause of autocompletion and diagnostics not working for Angular v21+ projects.
Closes #77
Relates to #69