Skip to content

Update tree-sitter-angular to v0.8.3#79

Merged
notpeter merged 1 commit intonathansbradshaw:mainfrom
pmig:fix/update-tree-sitter-grammar
Feb 25, 2026
Merged

Update tree-sitter-angular to v0.8.3#79
notpeter merged 1 commit intonathansbradshaw:mainfrom
pmig:fix/update-tree-sitter-grammar

Conversation

@pmig
Copy link
Contributor

@pmig pmig commented Feb 25, 2026

Summary

  • Updates the tree-sitter-angular grammar dlvandenberg/tree-sitter-angular@8b4f7e6...f0d0685

  • Includes 5 upstream bug fixes:

    • Complex CSS classes breaking parsing
    • Template string as primitive
    • Hyphen in identifier
    • Percentage sign as unit for style property binding
    • Class attribute modifier starting with hyphen

Test plan

  • Verify WASM build passes (cargo build --release --target wasm32-wasip1)
  • Verify grammar compiles correctly when installed as dev extension
  • Test parsing of Angular templates with complex CSS classes and style bindings

Relates to #55 (interrupted syntax highlighting with specific characters)

🤖 Generated with Claude Code

Update grammar commit from 8b4f7e6 to f0d0685 (Feb 17, 2026).

This brings 5 upstream fixes from dlvandenberg/tree-sitter-angular:
- fix(85): complex css classes no longer break parsing
- fix: template string as a primitive
- fix: allow hyphen in identifier
- fix: percentage sign as unit for style property binding
- fix: class attribute modifier could start with a hyphen

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 25, 2026 13:17

This comment was marked as off-topic.

@notpeter
Copy link
Collaborator

I'm not sure that splitting these into half a dozen PRs makes sense. A bunch of them cannot actually be tested in isolation (e.g. tree-sitter bump in this PR and tree-sitter query changes in another).

Seeing "Test Plan" with unchecked items makes me assume you have not bothered to even test this PR at all. And the final item in that list makes me assume you haven't even read the text of the generated PR description at all:

Test parsing of Angular templates with complex CSS classes and style bindings

This is unactionable slop (complex? what sort, etc). It feels awfully close to you being a proxy for the LLM assigning work to a maintainer (generate unscoped test cases for this untested code). Also saying "relates to #55 " doesn't tell me whether it fixes that or whether that's just the LLM included reference to that in the prompt (and how to verify that).

I know social norms differ about this sort of stuff, but personally this doesn't leave a good first impression to see six PRs which I'm pretty sure you didn't read.

I appreciate the contributions, but please take a moment to read your PR descriptions and them edit them to (1) reflect whether you've tested these changes and (2) remove as much unnecessary LLM filler text as possible.

Thanks.

@notpeter notpeter changed the title fix: update tree-sitter-angular grammar to latest Update tree-sitter-angular to v0.8.3 from v0.8.0 Feb 25, 2026
@notpeter notpeter changed the title Update tree-sitter-angular to v0.8.3 from v0.8.0 Update tree-sitter-angular to v0.8.3 Feb 25, 2026
@notpeter notpeter merged commit 487e669 into nathansbradshaw:main Feb 25, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants