Skip to content

Security Fix for Two Prototype Pollution - huntr.dev #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntr-helper wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Security Fix for Two Prototype Pollution - huntr.dev #2

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99f34cb
Fixed Prototype Pollution
mufeedvh Apr 17, 2020
5db156d
minor mistake fixed ✔️
mufeedvh Apr 17, 2020
6268c2c
Merge pull request #2 from mufeedvh/master
huntr-helper Apr 24, 2020
606688c
Freeze the prototype of a newly created object to prevent pollution w…
bbeale Jul 24, 2020
de12b7b
Go a step further than freezing the prototype and filter out prototyp…
bbeale Jul 26, 2020
beda0a4
Merge pull request #3 from bbeale/master
JamieSlome Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,20 @@ hashmap.apply = function(_, keyvals) {

exports.assocInM = assocInM
function assocInM(obj, keys, value) {
/*
`Object.create()` to set the object to not have any prototype
to prevent prototype pollution attacks
*/
obj = Object.create(obj)
Object.freeze(obj.prototype);

keys = keys.filter(function(item) {
var protoMod = item.includes("proto")
if (protoMod)
console.log("[!] prototype modification is potentially dangerous.");
return !protoMod;
})

var ret = obj
, key

Expand Down