fix: validate dotnet path exists before returning from TryFindDotNetExePath#607
Merged
natemcmaster merged 2 commits intomainfrom Apr 5, 2026
Merged
fix: validate dotnet path exists before returning from TryFindDotNetExePath#607natemcmaster merged 2 commits intomainfrom
natemcmaster merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 80.00% 80.01%
=======================================
Files 120 120
Lines 4061 4063 +2
Branches 879 880 +1
=======================================
+ Hits 3249 3251 +2
+ Misses 623 622 -1
- Partials 189 190 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…xePath TryFindDotNetExePath() was always returning a constructed path even when the file didn't exist (e.g., /usr/local/share/dotnet/dotnet on Alpine). This prevented FullPathOrDefault() from falling back to just "dotnet". Added File.Exists check and extracted FindDotNetInRoot as an internal method for testability. Added tests covering exists/not-exists scenarios. Fixes #600 Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
natemcmaster
force-pushed
the
claude/issue-600-20260405-0456
branch
from
d191a2b to
637cf90
Compare
|
Claude finished @natemcmaster's task in 27s —— View job Code Review for PR #607
Looks good! The fix is clean and correct — extracting the Tests cover the key scenarios (file exists, file doesn't exist, directory doesn't exist) and the No issues found. |
This was referenced Apr 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #600
TryFindDotNetExePath()was always returning a constructed path even when the file didn't exist (e.g.,/usr/local/share/dotnet/dotneton Alpine). This preventedFullPathOrDefault()from falling back to just"dotnet".Added
File.Existscheck and tests covering exists/not-exists scenarios.Generated with Claude Code