updated import with numpy array to handle dictionaries with values th…#523
Open
updated import with numpy array to handle dictionaries with values th…#523
Conversation
…at contain numpy arrays.
|
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
|
Benchmarking Results
|
Codecov Report
@@ Coverage Diff @@
## dev #523 +/- ##
==========================================
- Coverage 80.77% 79.18% -1.59%
==========================================
Files 53 30 -23
Lines 6074 2369 -3705
==========================================
- Hits 4906 1876 -3030
+ Misses 1168 493 -675
... and 23 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matteocorbetta
approved these changes
Apr 25, 2023
Contributor
matteocorbetta
left a comment
There was a problem hiding this comment.
Approved, since the DictLikeMatrixWrapper will be completely different in a week! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added "from numpy import array" for dictionaries that contain numpy arrays as values.