Skip to content

Prog models feature/cleanup/test sim result#500

Draft
mstraut wants to merge 3 commits intodevfrom
prog_models_feature/cleanup/test_sim_result
Draft

Prog models feature/cleanup/test sim result#500
mstraut wants to merge 3 commits intodevfrom
prog_models_feature/cleanup/test_sim_result

Conversation

@mstraut
Copy link
Copy Markdown
Contributor

@mstraut mstraut commented Feb 27, 2023

housekeeping: cleaned up variables, updated imports.

test_sim_result.py
test_sim_result.py

fixed containers.py imports
@mstraut mstraut requested a review from teubert February 27, 2023 20:56
@github-actions
Copy link
Copy Markdown

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All tests must be passing.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@mstraut mstraut marked this pull request as draft February 27, 2023 22:35
@mstraut mstraut marked this pull request as ready for review February 27, 2023 22:50
@mstraut mstraut marked this pull request as draft February 27, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant