Skip to content

Fix #2439, UT updates for alternate time configuration#2608

Open
thnkslprpt wants to merge 2 commits intonasa:mainfrom
thnkslprpt:fix-2439-update-tests-for-external-time-source
Open

Fix #2439, UT updates for alternate time configuration#2608
thnkslprpt wants to merge 2 commits intonasa:mainfrom
thnkslprpt:fix-2439-update-tests-for-external-time-source

Conversation

@thnkslprpt
Copy link
Copy Markdown
Contributor

@thnkslprpt thnkslprpt commented Sep 28, 2024

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Tested locally to confirm cFS builds without error and tests passing for all 3 external time source options:

  • CFE_PLATFORM_TIME_CFG_SRC_MET
  • CFE_PLATFORM_TIME_CFG_SRC_GPS
  • CFE_PLATFORM_TIME_CFG_SRC_TIME

Expected behavior changes
No change to code - test updates only.

System(s) tested on
Debian GNU/Linux 12 (bookworm)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@gregory1207
Copy link
Copy Markdown

I'm looking for exactly this change.

@dzbaker dzbaker added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 9, 2025
@dzbaker dzbaker force-pushed the fix-2439-update-tests-for-external-time-source branch from c268dd3 to 48101c8 Compare March 2, 2026 14:50
@dzbaker dzbaker removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 2, 2026
@dzbaker
Copy link
Copy Markdown
Collaborator

dzbaker commented Mar 2, 2026

Looks good! Re-synched with latest version of codebase.

@dzbaker dzbaker added this to the v7.0.1 milestone Apr 20, 2026
@chillfig chillfig self-requested a review April 20, 2026 15:53
Copy link
Copy Markdown
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ran lcov locally with the changes and config values:
DEFAULT_CFE_MISSION_TIME_CFG_FAKE_TONE = false
DEFAULT_CFE_PLATFORM_TIME_CFG_SOURCE = true
DEFAULT_CFE_PLATFORM_TIME_CFG_SRC_MET = true

This exposes less than 100% coverage in TIME. Reported in #2695. Approving this PR #2608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

time unit tests are broken if CFE_PLATFORM_TIME_CFG_SRC_MET is set to true

4 participants