Fix header guard macro typo in todimpl.h coverage stub#489
Open
Sammy-Dabbas wants to merge 1 commit into
Open
Conversation
Sammy-Dabbas
force-pushed
the
issue-1039-todimpl-guard
branch
from
096bfae to
990728f
Compare
The #ifndef guard read OVERRIDE_TOOIMPL_H while the #define reads OVERRIDE_TODIMPL_H, tripping clang's -Werror=header-guard and breaking the native build. Align the ifndef with the define and the OVERRIDE_<FILENAME>_H convention used by sibling override headers. Resolves nasa/cFS#1039.
Sammy-Dabbas
force-pushed
the
issue-1039-todimpl-guard
branch
from
990728f to
57717c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes the header guard typo reported in nasa/cFS#1039. In
unit-test-coverage/ut-stubs/override_inc/rtems/score/todimpl.hthe#ifndefguard readOVERRIDE_TOOIMPL_H(double O) while the#defineon the next line readsOVERRIDE_TODIMPL_H. Clang's-Werror=header-guardrejects the mismatch, breaking the native build.One-line change: align the
#ifndefwith the existing#define, matching theOVERRIDE_<FILENAME>_Hconvention used by the sibling override headers in the same directory (threadimpl.h,timestampimpl.h).Testing performed
OVERRIDE_TOOIMPL_His referenced nowhere else.Expected behavior changes
None at runtime; native builds with clang header-guard checking no longer fail.
Contributor Info
Sammy Dabbas, University of Central Florida