Fix #84, Remove superfluous assignments at the top of functions#85
Open
thnkslprpt wants to merge 1 commit intonasa:mainfrom
Open
Fix #84, Remove superfluous assignments at the top of functions#85thnkslprpt wants to merge 1 commit intonasa:mainfrom
thnkslprpt wants to merge 1 commit intonasa:mainfrom
Conversation
2 tasks
thnkslprpt
force-pushed
the
fix-84-remove-superfluous-assignments
branch
2 times, most recently
from
b782e46 to
7368127
Compare
thnkslprpt
force-pushed
the
fix-84-remove-superfluous-assignments
branch
from
7368127 to
bc09c69
Compare
Contributor
Author
|
@dzbaker - do you know what happened with this by any chance? |
Contributor
|
This appears to have been closed without merging. Reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #84
Extraneous assignments at the top of functions were removed.
Code is cleaner, and future maintainability is improved.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt