Fix CodeSonar Uninitialized Variable warning#126
Open
thesamprice wants to merge 1 commit intonasa:mainfrom
Open
Fix CodeSonar Uninitialized Variable warning#126thesamprice wants to merge 1 commit intonasa:mainfrom
thesamprice wants to merge 1 commit intonasa:mainfrom
Conversation
Location: fsw/src/fm_cmd_utils.c:544 Function: FM_GetVolumeFreeSpace Rule: Uninitialized Variable Level: error Rank: 62.739559173583984/100 Description: FileStats was not initialized. - FileStats was defined at fm_cmd_utils.c:536. The issue can occur if the highlighted code executes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
thesamprice
commented
Mar 3, 2026
| osal_status_t OS_Status; | ||
| CFE_Status_t Result; | ||
|
|
||
| memset(&FileStats, 0, sizeof(FileStats)); |
Author
There was a problem hiding this comment.
Should this only be meset to 0 on failure instead of all the time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location: fsw/src/fm_cmd_utils.c:544
Function: FM_GetVolumeFreeSpace
Rule: Uninitialized Variable
Level: error
Rank: 62.739559173583984/100
Description:
FileStats was not initialized. - FileStats was defined at fm_cmd_utils.c:536. The issue can occur if the highlighted code executes.
🤖 Generated with Claude Code
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)