fix: correct SFX ma_std_dev warmup issue by filtering None values (closes #154)#177
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
SFXindicator was producing an anomalous first value forma_std_dev(e.g., 9992.06 instead of ~2.08). This happened becausema_std_devwas constructed withinput_indicator=self.std_dev, causing it to receiveNonevalues duringstd_dev's warmup period. TheseNonevalues corrupted the internal state of the moving average.Fix
Removed
input_indicator=self.std_devfrom thema_std_devconstructor and instead registered it as a managed sequence viaadd_managed_sequence. The_calculate_new_valuemethod already manually reads fromma_std_dev, so we need to feed it valid values only. The managed sequence approach ensuresma_std_devonly receives valid (non-None) values fromstd_dev.Closes #154