fix: correct SFX ma_std_dev warmup by not feeding None values from std_dev (closes #154)#176
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
ma_std_devinsideSFXwas connected tostd_devviainput_indicator=self.std_dev. This causedma_std_devto receiveNonevalues duringstd_dev's warmup period, leading to incorrect (wildly large) values whenma_std_devfirst became active.Fix
Remove the
input_indicatorlinkage and instead registerma_std_devas a managed sequence. Feedma_std_devonly valid values fromstd_devinside_calculate_new_value, matching the pattern used in other indicators.Closes #154