Skip to content

Repository file finder /find path-list contract (search-007-final)#38

Open
jaeyunha wants to merge 1 commit into
stagingfrom
qa/search-007-final
Open

Repository file finder /find path-list contract (search-007-final)#38
jaeyunha wants to merge 1 commit into
stagingfrom
qa/search-007-final

Conversation

@jaeyunha

Copy link
Copy Markdown
Member

/find path-list contract for client-side fuzzy filtering.


Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against staging for review.

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4336c8a29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,93 @@
import { execFileSync } from "node:child_process";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the shared auth fixture for this signed-in spec

For this new signed-in Playwright spec, web/tests/e2e/AGENTS.md requires all new signed-in specs to go through _fixtures/auth.ts and explicitly says not to import execFileSync. Manually running the Rust seeder and minting cookies here bypasses the standardized scene/persona setup, so fixture contract changes or required shared assertions can break or be skipped only in this test; import test, expect, and signIn/seed from the auth fixture instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant