Skip to content

Wiki: revision-history hrefs + error mapping (wiki-001)#34

Open
jaeyunha wants to merge 1 commit into
stagingfrom
qa/wiki-001-visible-20260513094804
Open

Wiki: revision-history hrefs + error mapping (wiki-001)#34
jaeyunha wants to merge 1 commit into
stagingfrom
qa/wiki-001-visible-20260513094804

Conversation

@jaeyunha

Copy link
Copy Markdown
Member

Wiki revision-history hrefs plus InvalidSecurityPolicy error mapping.


Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against staging for review.

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85fca83bbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

) -> String {
let base = slug
.map(|slug| format!("{}/_history", wiki_page_href(repository, slug)))
.map(|slug| format!("{}/_history", wiki_page_scoped_href(repository, slug)))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope the Home page History button too

This only fixes callers that go through wiki_history_href; wiki_page_from_row still serializes page.historyHref with wiki_page_href(...), so the Home page payload remains /{owner}/{repo}/wiki/_history. The reader UI uses page.historyHref for its History button, so on Home users still land on all-pages history instead of the page-scoped /wiki/Home/_history revision history this change is trying to restore.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant