Skip to content

Repository file finder: /find path-cache contract (search-007)#33

Open
jaeyunha wants to merge 1 commit into
stagingfrom
qa/search-007-visible-20260514112127
Open

Repository file finder: /find path-cache contract (search-007)#33
jaeyunha wants to merge 1 commit into
stagingfrom
qa/search-007-visible-20260514112127

Conversation

@jaeyunha

Copy link
Copy Markdown
Member

/find endpoint returns the full ref file-path list for a client-side path cache; finder UI renders all scored files.


Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against staging for review.

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71951837a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

getRepositoryFileFinder(ownerLogin, repositoryName, refName, "", {
page: 1,
pageSize: 100,
pageSize: 5000,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fetch the entire path cache for file finder

On refs with more than 5,000 files, this page fetches only page 1 with pageSize=5000 and then performs all fuzzy filtering against that truncated finder.items array. That means paths after the first 5,000 can never appear, be matched, or be opened, even though the /find contract for search-007 is to fuzzy-match locally against the full ref path list; the page needs to paginate through the cache or use an unpaginated path-cache response.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant