Skip to content

Actions: server-side job-log prefetch + in-page log search (actions-009)#31

Open
jaeyunha wants to merge 1 commit into
stagingfrom
qa/actions-009-visible-retry7-20260514071926
Open

Actions: server-side job-log prefetch + in-page log search (actions-009)#31
jaeyunha wants to merge 1 commit into
stagingfrom
qa/actions-009-visible-retry7-20260514071926

Conversation

@jaeyunha

Copy link
Copy Markdown
Member

Server-side initial job-log prefetch and optimistic in-page log search filtering on the Actions run page. Selected as the most complete of several competing actions-009 job-log attempts.


Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against staging for review.

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22d8189d58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Logs are not available yet.
</p>
) : logState === "loading" ? (
) : logState === "loading" && !log ? (

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear stale logs when switching jobs

When a user has already loaded one job's log and then selects another log-enabled job, this new && !log condition falls through to the log rendering branch because jobLog still contains the previous job's lines while the fetch for the new job is loading. That makes the newly selected job panel show the old job's log (labeled as refreshing) until the request completes, or indefinitely on a slow/hung request; please clear jobLog on job changes or only reuse stale logs when log.job.id === job.id for same-job searches.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant