Repository contributors UI + e2e (insights-005)#28
Conversation
Tested: make doctor; make check; TEST_DATABASE_URL=postgresql://opengithub:***@localhost:55433/opengithub_test ./hack/cargo_locked.sh test -p opengithub-api --test repository_dependency_graph_contract -- --nocapture; PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/usr/bin/google-chrome PLAYWRIGHT_BROWSERS_PATH=$HOME/.cache/ms-playwright npx playwright test tests/e2e/repository-dependency-graph.spec.ts --project=chromium --reporter=list Confidence: high Co-authored-by: OmX <omx@oh-my-codex.dev>
Detached-HEAD QA_PASS commit (251f611) was not on origin; backed up before worktree cleanup. QA: biome clean (web). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0f51dff44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await page.getByRole("textbox", { name: "Search" }).fill("playwright"); | ||
| await page.getByRole("button", { name: "Apply" }).click(); | ||
| await expect(page.getByRole("button", { name: "Apply" })).toBeVisible(); | ||
| await page.goto(`${repositoryHref}/network/dependencies?q=playwright`); |
There was a problem hiding this comment.
When the dependency search form wiring regresses, this E2E will still pass because it fills the Search box but then manually navigates to the expected query URL instead of clicking the visible Apply button. This removes coverage for the actual browser interaction the user performs; use the Apply control after filling the field, as the previous spec did, so broken form/action wiring is caught.
Useful? React with 👍 / 👎.
| const exportResponse = await page.request.post( | ||
| `${repositoryHref}/network/dependencies/sbom`, | ||
| ); |
There was a problem hiding this comment.
When the RepositoryDependencyExportButton client handler or rendered button/link breaks, this test will still pass because it calls the SBOM route directly through page.request.post rather than pressing Export SBOM in the page. The smoke no longer verifies the pending/success UI state or that a user can reach the download link from the button, so this should exercise the button and assert the rendered Download SBOM link instead of bypassing the component.
Useful? React with 👍 / 👎.
1 participant
Repository contributors controls/table/page components plus e2e fixtures and specs. Recovered from a detached-HEAD QA_PASS commit that was on no remote.
—
Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against
stagingfor review.🤖 Generated with Claude Code