Actions job-log page UX refinements (actions-007)#25
Conversation
Backed up before worktree cleanup. QA: biome clean, vitest 8/8 pass (web). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a0c0537ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| format!("attachment; filename=\"{filename}.gz\""), | ||
| ) | ||
| .body(Body::from(body)) | ||
| .body(Body::from(gzip_bytes(body)?)) |
There was a problem hiding this comment.
This now returns gzipped bytes from /api/repos/.../actions/jobs/.../logs/download for every caller, but the existing crates/api/tests/api_repository_actions_run_detail_contract.rs contract still calls get_text(...) on that endpoint and asserts a plain log substring. When that test runs, String::from_utf8 will receive gzip bytes and fail before the assertion, so the Rust test suite is broken unless that remaining consumer is converted to gunzip (or this route stays text/plain).
Useful? React with 👍 / 👎.
1 participant
UX refinements to the Actions job-log page and related download route + tests.
—
Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against
stagingfor review.🤖 Generated with Claude Code