Project templates settings UI (projects-007)#24
Conversation
Backed up before worktree cleanup. QA: biome clean, vitest 12/12 pass (web). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26153d3e27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { execFileSync } from "node:child_process"; | ||
| import { expect, type Page, test } from "@playwright/test"; |
There was a problem hiding this comment.
Use the shared auth fixture for this spec
This is a new signed-in E2E spec, but it imports @playwright/test directly and calls the Rust seeder via execFileSync instead of using ./_fixtures/auth; web/tests/e2e/AGENTS.md explicitly makes that fixture the contract for new signed-in specs so scene env vars, cookie shape, and future seeder changes stay centralized. As written, this test is the kind of direct-seeder caller the fixture warns will break when the seeder/auth contract changes.
Useful? React with 👍 / 👎.
| <Link | ||
| className="list-row" | ||
| href={settingsHref(scope, owner, projectNumber, "workflows")} | ||
| > |
There was a problem hiding this comment.
Keep workflow navigation working for templates
When a project is already a template, or immediately after this page marks it as one, this Workflows link routes to /projects/:number/workflows, but the workflow route still resolves numbers only from the open/closed project list; those list items exclude templates, while only the workspace/field/settings resolvers were updated to search the templates tab. The result is a workflow-unavailable page from the new template settings UI even though the page advertises workflows as part of the copyable template, so either resolve workflow settings through templates too or hide this link for template projects.
Useful? React with 👍 / 👎.
New project-templates settings pages + ProjectTemplateSettingsPage component, plus projects/milestones domain updates.
—
Preserved from QA-worktree cleanup on 2026-06-16. Web QA: biome lint clean; vitest green where unit tests exist. Rust build/test not run locally (would regenerate large target dirs). Opened against
stagingfor review.🤖 Generated with Claude Code