Skip to content

Backend: Payment settlement report parsing#1160

Merged
hkmangla merged 2 commits intomainfrom
backend-feat-parsing-settlement-report
Mar 10, 2026
Merged

Backend: Payment settlement report parsing#1160
hkmangla merged 2 commits intomainfrom
backend-feat-parsing-settlement-report

Conversation

@kavya-shree-s
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kavya-shree-s kavya-shree-s force-pushed the backend-feat-parsing-settlement-report branch 2 times, most recently from 36c36d8 to f1f898a Compare March 10, 2026 12:50
{ imapHost :: Text,
imapPort :: Int,
username :: Text,
password :: Text,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep password encrypted.

{ host :: Text,
port :: Int,
username :: Text,
password :: Text,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep password encrypted.

@@ -0,0 +1 @@
module Kernel.Prelude.OrphanInstances () where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

import GHC.Generics (Generic)
import Prelude

newtype HighPrecMoney = HighPrecMoney
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this type and all? Why again and what is shims?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-settlement-parser is a standalone test project created only for local testing. If we plan to reuse it across environments, we would need to set up a Nix build system for it. Since its current purpose is just local testing, I created it separately. If it’s not required, I can remove test project from the PR.

@kavya-shree-s kavya-shree-s force-pushed the backend-feat-parsing-settlement-report branch from f1f898a to ac932b1 Compare March 10, 2026 13:57
@kavya-shree-s kavya-shree-s force-pushed the backend-feat-parsing-settlement-report branch from ac932b1 to a97a147 Compare March 10, 2026 13:57
@hkmangla hkmangla merged commit 98be8d6 into main Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants