Conversation
🦋 Changeset detectedLatest commit: 538dc75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Thanks for updates. Reviewed and shared feedback 👍
| @@ -698,7 +778,9 @@ export class NameGuard { | |||
| options?: SecurePrimaryNameOptions, | |||
| ): Promise<SecurePrimaryNameResult> { | |||
There was a problem hiding this comment.
Please also check the nameguard-js package and see if there's anything there that needs to be updated. NameGuard JS implements a subclass of the NameGuard class.
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Hey just saw your updated comments here. Reviewed and shared feedback 👍
notrab
requested review from
BanaSeba,
Carbon225,
FrancoAguzzi,
djstrong and
edulennert
as code owners
packages/nameguard-sdk/src/index.ts
Outdated
| try { | ||
| const timeoutId = setTimeout(() => { | ||
| this.abortController.abort(); | ||
| }, 30000); // 30 second timeout |
There was a problem hiding this comment.
We could make this configurable if we need.
I think we could attach timeout to the signal instead from looking at this page. I need to test it.
There was a problem hiding this comment.
I've added this to the constructor now.
2 participants
Earlier this year we discussed the idea of adding different error types to the SDK for timeouts, lost connection, server errors and input validation.
This PR starts the conversation about adding such support.
Please note;
nameguard-react