updated GazeBase dataset to have "time_stamps"#214
Open
najam-tariq wants to merge 2 commits intomainfrom
Open
Conversation
Collaborator
najam-tariq
commented
Dec 24, 2024
najam-tariq
commented
- Contributes to update all datasets to include time_staps in JSON files #205
nalmadi
requested changes
Dec 24, 2024
Owner
nalmadi
left a comment
nalmadi
left a comment
There was a problem hiding this comment.
Datasets are very important and they deserve paying a lot of attention to making sure that they are reliable. The current batch doesn't meet the standards for scientific research, the data contains clear errors. Please make sure that the files are 100% correct before you make a future PR. Thank you!
| 60160.0 | ||
| ], | ||
| "fixations": [ | ||
| [ |
Owner
There was a problem hiding this comment.
First fixation repeats twice. Can you please double check such issues in all files?
| @@ -1,5 +1,356 @@ | |||
| { | |||
| "time_stamps": [ | |||
| 505.0, | |||
Owner
There was a problem hiding this comment.
timestamps should not repeat. Also, there's a huge gap between the second and 3rd fixation. This can't be right, saccades are never that long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.