Skip to content

chore: repoint pr-review skill to agents-shared capability#42

Open
eskenazit wants to merge 1 commit into
mainfrom
chore/agents-shared-pr-review
Open

chore: repoint pr-review skill to agents-shared capability#42
eskenazit wants to merge 1 commit into
mainfrom
chore/agents-shared-pr-review

Conversation

@eskenazit

Copy link
Copy Markdown
Contributor

Related Issue

Refs naftiko/shipyard#23


What does this PR do?

Repoints the pr-review skill discovery from the hardcoded framework repo path to the
new agents-shared capability hosted in code-standards.

Three changes:

  • AGENTS.md — PR Review Skill section replaced: drops the old framework/.agents/
    path reference and TODO; adds a four-line pointer to the capability + instruction shim.
    Also clarifies issue-first wording ("ensure a tracking issue exists" rather than "open
    an issue before every change").
  • .gitignore — adds .agents/skills/ so on-demand synced skill copies are never
    accidentally committed.
  • .github/instructions/agents-shared.instructions.md — discovery shim (copied from
    code-standards/agents-shared/instructions/). VS Code agents load it on trigger keywords
    (review PR, fix PR comments, …), check for a local copy of the skill, sync it from the
    Skill Server if missing, then follow SKILL.md.

Tests

No production code changed. End-to-end validated manually: VS Code agent discovered the
instruction, synced the pr-review skill from the local Skill Server (port 9700), and
executed pr-context.ps1 -Pr 33 successfully.


Checklist

  • CI is green (build + tests)
  • Rebased on latest main
  • Small and focused — one concern per PR
  • Commit messages follow Conventional Commits
  • Apache 2.0 license header present on any new Java file (no new Java files)

Agent Context (optional)

agent_name: GitHub Copilot
llm: Claude Sonnet 4.6
tool: VS Code Copilot Chat
confidence: high
source_event: naftiko/shipyard#23
discovery_method: user_report
files_suspected:
  - AGENTS.md
  - .gitignore
  - .github/instructions/agents-shared.instructions.md

AGENTS.md: replace PR Review Skill section with pointer to the
agents-shared capability (drop hardcoded framework path + TODO);
clarify issue-first wording to 'ensure a tracking issue exists'.

.gitignore: add .agents/skills/ so synced copies are never committed.

.github/instructions/: add agents-shared discovery shim so VS Code
agents auto-fetch the pr-review skill from the local Skill Server.

Refs naftiko/shipyard#23
@eskenazit eskenazit requested review from jeremnaf and jlouvel June 10, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant