Add feature to allow compatability with Venafi TPP ACME servers#118
Add feature to allow compatability with Venafi TPP ACME servers#118arontsang wants to merge 1 commit intonabsul:mainfrom
Conversation
|
Thanks for the contribution! I will try to get the change reviewed and merged in the next few weeks. Please feel free to remind me if you don't hear back by end of this month :-) |
| // Try searching for account before account creation. | ||
| // This is needed for the Venafi implementation of ACME | ||
| // since they do NOT follow RFC8555 Section 7.3.1 | ||
| return await PostAsync<AcmeAccountResponse>(cfg.AcmeKey, uri, new { onlyReturnExisting = true }, nonce); |
There was a problem hiding this comment.
I think instead of using exception handling to switch between the regular approach and what Vanafi needs, a configuration parameter would be better.
| if (!resp.IsSuccessStatusCode) | ||
| { | ||
| var content = await resp.Content.ReadAsStringAsync(); | ||
| AcmeError? error = null; |
There was a problem hiding this comment.
This structure looks odd. Can it be written in a clearer way?
|
@arontsang Thanks again for submitting this, but I don't think I can accept it in its current form. I left some more detailed comments in the code. For this project I strongly value making small non-breaking changes. Ideally, new features and breaking changes should be controlled by a configuration parameter that is off by default. |
| public required string Type { get; init; } | ||
| public required string Detail { get; init; } | ||
| public int Status { get; init; } | ||
| } No newline at end of file |
There was a problem hiding this comment.
also please fix styling issues as much as possible, like the missing new line at the end of this file.
2 participants
No description provided.