Added overloaded function ServoTimer2::attach(int pin, int min_pulse_width, int max_pulse_width)#5
Open
ld21 wants to merge 2 commits intonabontra:masterfrom
Open
Added overloaded function ServoTimer2::attach(int pin, int min_pulse_width, int max_pulse_width)#5ld21 wants to merge 2 commits intonabontra:masterfrom
ld21 wants to merge 2 commits intonabontra:masterfrom
Conversation
Added missing overloaded function ServoTimer2::attach(int pin, int min_pulse_width, int max_pulse_width); MIN_SERVO_PULSE and MAX_SERVO_PULSE are no longer #defined but real variables that can be set.
MIN_PULSE_WIDTH and MAX_PULSE_WIDTH are no longer #defineD, but real variables, that can be set in the constructor.
ld21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the overloaded function ServoTimer2::attach(int pin, int min_pulse_width, int max_pulse_width) as it was planned according to ServoTimer2.h from the start. Seems to work well and now also non-standard servos that need non-standard timings can be controlled using this very handy library. Thank you for trying it out.