Open
Conversation
Owner
|
Sorry for the lateness here, I only just recently had enough time to start getting back into this stuff. My only concern with this macro is that it blocks due to the hidden loop, so someone could inadvertently call it from inside an async function thinking it will implicitly yield. That's why all current A name that makes this very clear might be acceptable:
Then it's maybe a little clearer what's going on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like how you have the
awaitmacro built, but it wasn't usable from a synchronous function likemain, so I made this alternative. I know it isn't super necessary, but I really like the way it pulls together with the rest of the async.h project