Merged
Conversation
Primarily to get new classifiers for showing supported python version on PyPi (and in the badge in the readme here). It's easy to verify this locally by using `uvx` to run versions of poetry to build the .whl, and examine the wheel metadata: ```bash ❯ uvx --from=poetry==1.4.0 poetry -q build && unzip -q dist/nrfcloud_utils-*-py3-none-any.whl && rg 'Classifier: Programming Language :: Python' nrfcloud_utils-*.dist-info/METADATA && rm -rf nrfcloud_utils* 10:Classifier: Programming Language :: Python :: 3 11:Classifier: Programming Language :: Python :: 3.10 12:Classifier: Programming Language :: Python :: 3.11 ❯ uvx --from=poetry==2.2.1 poetry -q build && unzip -q dist/nrfcloud_utils-*-py3-none-any.whl && rg 'Classifier: Programming Language :: Python' nrfcloud_utils-*.dist-info/METADATA && rm -rf nrfcloud_utils* 10:Classifier: Programming Language :: Python :: 3 11:Classifier: Programming Language :: Python :: 3.10 12:Classifier: Programming Language :: Python :: 3.11 13:Classifier: Programming Language :: Python :: 3.12 14:Classifier: Programming Language :: Python :: 3.13 15:Classifier: Programming Language :: Python :: 3.14 ```
There was a problem hiding this comment.
Pull request overview
This PR updates the Poetry version used in CI workflows from 1.4.2 to 2.2.1, enabling newer Python version classifiers (3.12, 3.13, 3.14) to be displayed on PyPI. The update introduces a centralized POETRY_VERSION environment variable for consistent version management across all workflow jobs.
- Centralizes Poetry version in a workflow-level environment variable
- Updates Poetry from 1.4.2 to 2.2.1 in both build and publish jobs
- Enables proper Python version classifiers for newer Python versions on PyPI
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
maxd-nordic
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily to get new classifiers for showing supported python version on
PyPi (and in the badge in the readme here).
It's easy to verify this locally by using
uvxto run versions of poetry tobuild the .whl, and examine the wheel metadata: