feat: added 'alt' and 'dist' to ground fix schema#68
Open
coleHafner wants to merge 1 commit intov1from
Open
Conversation
plskeggs
approved these changes
Oct 18, 2024
Contributor
plskeggs
left a comment
plskeggs
left a comment
There was a problem hiding this comment.
Seems ok, but we will be unable to add to the device side anytime soon.
jayteemo
approved these changes
Oct 22, 2024
lincolnthomas
approved these changes
Oct 25, 2024
Contributor
lincolnthomas
left a comment
lincolnthomas
left a comment
There was a problem hiding this comment.
LGTM! I understand this won't be merged until the changes have been deployed to Production.
Contributor
The schema can be published independently of any future firmware support, so this is OK. |
Contributor
|
@coleHafner is this delayed until future notice? |
Contributor
Author
|
@plskeggs this is available on the REST API. I believe MQTT too, but will double check tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** THIS IS WILL NOT BE MERGED UNTIL EARLY DEC WHEN FEATURE IS RELEASED ON BE **
Problem
Backend has new flags that are not documented here.
Solution
Document them!
Testing
npm test
Front End Changes Required
NONE
System Impact
NONE
Jira Tickets
IRIS-9796
Release Notes
Added docs for 'dist' and 'alt' flags on ground fix endpoint