feat(table): align table design in fe#2101
Open
Fiona2016 wants to merge 46 commits into
Open
Conversation
Per design-system-table.md token baseline, sorted body cells use rgb(var(--fc-fill-5-rgb) / 0.1), not the header bg (fill-2-5).
Short headers (≤4 chars) must not wrap; wide tables use horizontal scroll instead of squeezing the header.
…ob-tpls Per design-system-table.md §8: default pageSize is 15 across all tables. - alert-mutes (shield): drop defaultPageSize 30 override; inherit DEFAULT_PAGESIZE. - alert-subscribes (ListNG): drop defaultPageSize 30 override; inherit DEFAULT_PAGESIZE. - job-tpls: add 15 to pageSizeOptions so it is selectable.
Per design-system-table.md §17.3 PRD scope: - Column1Title: 订阅名称 - Column1Content: 业务组 Drop the standalone business_group column; show group as a sub-line under the subscribe name using the double-row identifier pattern (design-system §5).
…to Column1 Per design-system-table.md §17.3: - Column1Title: 规则标题 - Column1Content: 数据源类型 + 业务组 Drop the standalone business_group and cate columns; surface them as a sub-line beneath the rule title.
Per design-system-table.md §17.3: - Column1Title: 标题 - Column1Content: ID + 业务组
Per design-system-table.md §17.3: - Column1Title: 标题 - Column1Content: ID + 业务组
Per design-system-table.md §17.3: - Column1Title: 用户名 - Column1Content: 显示名 + 邮箱 + 手机号 Username keeps sorter; secondary identifiers shown beneath as text-soft.
…to Column2 Per design-system-table.md §17.3: - Column1: 状态 (kept as-is) - Column2Title: 名称 - Column2Content: 类型 (logo) + 业务组 + 级别 - Column3: 数据源 Drop standalone cate, group_id, severities columns; embed them under name. Trim defaultColumnsConfigs accordingly.
…-0509 # Conflicts: # src/pages/task/index.tsx # src/pages/taskTpl/index.tsx # src/pages/warning/shield/index.tsx
Sorted column TD was using antd default #fafafa while sorted TH inherited a different bg, making the column look split. Apply the same fc-fill-5 token to both so the whole column reads as one band. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Remove `visibility: collapse` on the rc-table measure row — Chrome treats it as collapsing layout, so MeasureCell reports offsetWidth=0 when there is no data. Combined with the recent fixed-right + scroll x:max-content rollout, empty-state tables had the first column absorb all available width. Inline `height:0; fontSize:0` on the tr already hides the row, so the rule was redundant anyway. Also flip the ping-right shadow gradient so the darker edge sits next to the fixed column instead of away from it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Standardize all table action column Dropdowns to use `click`-only trigger and explicit `align` prop for consistent positioning. Includes minor formatting fixes (indentation, JSX simplification).
- Add Tags component with two-line overflow layout and ResizeObserver - Use Tags in the event count column with triggered/normal status display - Add i18n entries for status text and popover title across all locales
… in hosts list Move Tags from alertRules scope to components/TableTags for cross-page reuse; replace TableTags usage in hosts list with the unified Tags component.
…y column - Refactor Tags component to support generic typed data via getKey/getLabel - Support per-item bgColor/fontColor/icon via function props - Add maxWidth/borderRadius props for layout control - Extract calcLayout and add comprehensive test suite - Move alert rule category icon to datasource column - Add severity column with color-coded per-level tags - Merge nickname column into username column - Add click-to-open notification rules with not-found warning
- Remove scroll={{ x: 'max-content' }} from all table components to
simplify layout behavior
- Replace TableTags with the new Tags component using outline style
and consistent maxWidth
- Add null-safety to Tags component (accept null data, early return)
- Split update_at into two-row layout (date + time) across all tables
- Combine update_by/update_by_nickname and create_by/create_by_nickname
into single columns with stacked display
- Inline business group name into metric name column in recordingRules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test