feat: Allow specifying backup type in start command#2
feat: Allow specifying backup type in start command#2google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This change implements the ability to specify a backup type (zip, differential, incremental) when manually starting a backup via the command line. This overrides the globally configured backup type for that specific run. Changes include: - `ThreadedBackup`: Added `forcedType` field and logic to use it if present. - `BackupWrapper`: Overloaded `makeSingleBackup` to accept an optional type. - `CoreCommandSystem`: Added `startBackup` overload to pass the type down. - `AdvancedBackupsCommand` (Fabric 1.21): Updated command registration to accept an optional `type` argument with suggestions. This fulfills the "One-off backup types" item from the future plans.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implemented "One-off backup types" for the
startcommand. Users can now run/backup start <type>(e.g.,/backup start zip) to force a specific backup type, overriding the config. This was implemented by updating the core logic to propagate the type preference and updating the Fabric 1.21 command registration.PR created automatically by Jules for task 17377191810575912783 started by @n1tr0maverick