fix(bbr3): Call on_packet_sent when ACK-eliciting data is sent#689
Merged
Conversation
It seems this was missed when this was ported from the upstream PR. This is different from #657 which was doing this unconditionally, regardless when the packet needed to be accounted for congestion control or whether it was ack-eliciting. I did not continue the tests. It's something extremely specific and artificial that is being tested. It's like testing everything with a mock, I'm not sure the value it provides is worth all the stuff that is setup. Ideally we figure out a better way to test that congestion controllers actually behave correctly sometime.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/689/docs/noq/ Last updated: 2026-06-03T13:54:58Z |
4 tasks
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5253.6 Mbps | 7881.9 Mbps | -33.3% | 95.9% / 100.0% |
| medium-concurrent | 5408.4 Mbps | 7743.0 Mbps | -30.2% | 95.8% / 148.0% |
| medium-single | 3808.2 Mbps | 4706.2 Mbps | -19.1% | 97.8% / 150.0% |
| small-concurrent | 3739.1 Mbps | 5228.9 Mbps | -28.5% | 93.9% / 102.0% |
| small-single | 3395.0 Mbps | 4772.3 Mbps | -28.9% | 92.8% / 101.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | N/A | 4050.6 Mbps | N/A |
| lan | N/A | 810.4 Mbps | N/A |
| lossy | N/A | 55.9 Mbps | N/A |
| wan | N/A | 83.8 Mbps | N/A |
Summary
noq is 28.8% slower on average
matheus23
approved these changes
Jun 3, 2026
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Seems to work with sendme for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems this was missed when this was ported from the upstream
PR. This is different from #657 which was doing this unconditionally,
regardless when the packet needed to be accounted for congestion
control or whether it was ack-eliciting.
I did not continue the tests. It's something extremely specific and
artificial that is being tested. It's like testing everything with a
mock, I'm not sure the value it provides is worth all the stuff that
is setup. Ideally we figure out a better way to test that congestion
controllers actually behave correctly sometime.
Breaking Changes
none
Notes & open questions
Replaces #657, I considered taking it over. But this way I can't
approve my own PR.
Change checklist