Use hpgsql-simple-compat instead of postgresql-simple#227
Draft
mzabani wants to merge 5 commits into
Draft
Conversation
…alid ctor for transaction state
… `Maybe a` values are necessary The error one gets is: ``` No instance for ‘hpgsql-0.1.6:HPgsql.Encoding.ToPgField ObjName ``` hpgsql-simple-compat needs a ToPgField instance for custom user types `a` if a `Maybe a` appears encoded as a query argument. The reason is without a typeOid postgres has to infer values, but `NULL` without a typeOid can't be inferred for every query.
…Exception anymore hpgsql-simple-compat will never throw an IOException
mzabani
force-pushed
the
use-hpgsql-simple-compat
branch
from
0686c43 to
6e03b9a
Compare
hpgsql isn't in nixpkgs yet, so they fail
mzabani
force-pushed
the
use-hpgsql-simple-compat
branch
from
6e03b9a to
1263568
Compare
mzabani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a branch to show how many changes were necessary to migrate codd from postgresql-simple and postgresql-libpq to hpgsql-simple-compat (from https://github.com/mzabani/hpgsql).
If you are coming here from hpgsql, I recommend reading each commit individually to see what it took to get codd to migrate to hpgsql-simple-compat. Only the last commit disables building related parts of the pipeline because hpgsql isn't in nixpkgs yet.
This is not to be merged yet because hpgsql lacks many authentication methods libpq provides.